Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295019

Improve JSWebAssert::waitOnAutocomplete

$
0
0

Problem/Motivation

This issue began with proposing improvements to assertions in EntityReferenceAutocompleteWidgetTest::testEntityReferenceAutocompleteWidget. That changed in #35 to improving \Drupal\FunctionalJavascriptTests\JSWebAssert::waitOnAutocomplete.

There was previously a random failure:

1) Drupal\FunctionalJavascriptTests\EntityReference\EntityReferenceAutocompleteWidgetTest::testEntityReferenceAutocompleteWidget
PHPUnit_Framework_Exception: Argument #2 (No Value) of PHPUnit_Framework_Assert::assertCount() must be a countable or traversable

/var/www/html/core/tests/Drupal/FunctionalJavascriptTests/EntityReference/EntityReferenceAutocompleteWidgetTest.php:73

This issue currently proposes to improve the assertion for future debugging.

Steps to reproduce

Proposed resolution

- Added support to check the autocomplete is opened on the correct field
- Added testing for the tags mode to increase coverage.

Remaining tasks

Reroll patch
review

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 295019

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>