Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294165

Branding block should include config dependency on system.site config

$
0
0

Problem/Motivation

When using drush config-set system.site name "Test 1", the site name unreliably updates, meaning, sometimes it updates right away and sometimes a cache-rebuild (drush cr) is required. The active config store is updated, but the block itself is not.

Proposed resolution

Adding a dependency to the configuration item "system.site" to block.block.bartik_branding.yml causes the block to update immediately if the configuration for the site name is updated via drush config-set:

dependencies:
  module:
    - system
  theme:
    - bartik
  config:
    - system.site

Remaining tasks

I have only tested this by adding this dependency to my exported config YAML file for block.block.bartik_branding.yml; next step is to create a patch that adds this dependency to the original Bartik block branding configuration file, which I understand from this issue (https://www.drupal.org/node/2642590), might be moving.

Need advice as to whether or not to wait for that issue to close or to go ahead with a patch in its current location.

User interface changes

None.

API changes

None.

Data model changes

None.


Viewing all articles
Browse latest Browse all 294165

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>