Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291349

Remove Taxonomy term reference field in favor of Entity reference

$
0
0

Problem/Motivation

Since Entity reference module patch went in the taxonomy reference field, duplicates functionality already provided by entity reference.

Proposed resolution

Turn existing taxonomy reference fields into entity reference ones and remove the taxonomy reference field.

The patch has been authored by the Entity Reference maintainers (@amitaibu and @amateescu) and has signoff from the Taxonomy module maintainer (@xjm). @Dries also approved the direction of the patch in #195 (as of November 2014, during the beta phase). Since it introduces significant disruption, it has an upgrade path deadline.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue categoryTask because there is no functional bug.
Issue priorityMajor because it:
  • Eliminates the usability regression of having two different (and incompatible) field types for the same functionality
  • Significantly reduces the amount of one-off code that must be maintained in Taxonomy
  • Provides a working example of an Entity Reference field in Standard
  • Fulfills the purpose of having Entity Reference in core in the first place
Prioritized changesThe main goal of this issue is usability. The patch also improves maintainability by removing what is essentially a second code path for the same functionality (diffstat: 373 insertions, 2042 deletions).
DisruptionThe patch introduces significant disruption:
  • All taxonomy fields on existing sites will be broken, and their data will need to be migrated to a new entity reference field, including the Tags field included with every Standard profile installation.
  • Configured Views, etc. using the field will need to be reconfigured.
  • Any modules altering taxonomy term reference fields will need significant changes.
  • Many core patches affecting the taxonomy module may need to be rerolled or significantly rewritten.

Remaining tasks

User interface changes

The taxonomy field storage and field settings are replaced by the entity reference ones.

API changes

The 'taxonomy_term_reference' field type is removed, including widgets, formatters, the taxonomy autocomplete controller, etc. All functionality is replaced with Entity Reference functionality.

Original report by Amitaibu

That's kind of the whole purpose of #1801304: Add Entity reference field :)


Viewing all articles
Browse latest Browse all 291349

Trending Articles