Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295330

Remove dead code from NodeRevisions[All]Test::setUp

$
0
0

Problem/Motivation

Both core/modules/node/tests/src/Functional/NodeRevisionsAllTest.php::setUp and \Drupal\Tests\node\Functional\NodeRevisionsTest::setUp code like
$settings = get_object_vars($node); after which nothing at all is done with $settings.

I tried to find out where they came from, but both both seem to come from a conversion of D7 node tests to PSR-0 around 2012/13.
I like some git-archeology, but if that goes further than 10 years without any more recent changes, I'm calling quits...

Steps to reproduce

Proposed resolution

Remove $settings = get_object_vars($node); and friends in both classes

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 295330

Trending Articles