Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 292452

Unify effect/operation verb naming in image style, image, toolkit, toolkit operation

$
0
0

Updated: Comment #0

Part of #2105863: [meta] Images, toolkits and operations. This was stated first time in #2103635-21: Remove effects from ImageInterface.

Problem/Motivation

Image processing has now several layers of abstraction:

LevelClassEffect/operation methodAbstraction
Image styleImageEffectInterfaceapplyEffect()Toolkit agnostic
ImageImageInterfaceapply()Toolkit agnostic
ToolkitImageToolkitInterfaceapply()Toolkit dependent
Toolkit operationImageToolkitOperationInterfaceapply()Toolkit dependent

The higher image style level has a different naming from the others.

Proposed resolution

Unify naming by renaming ImageEffectInterface::applyEffect() to ImageEffectInterface::apply().

Remaining tasks

N/A

User interface changes

No changes.

API changes

Renamed ImageEffectInterface::applyEffect() to ImageEffectInterface::apply().


Viewing all articles
Browse latest Browse all 292452

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>