Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294303

Make the {node_field_revision}.log column nullable so that we can simplify code and remove an if

$
0
0

Follow up for #1498674: Refactor node properties to multilingual

Problem/Motivation

Simplify code

In 1498674 was the @todo

-      // @todo: Make the {node_revision}.log column nullable so that we can

On the line in the patch in comment #303:
503

The line of the final patch might change but that info might help to find them.

For example,

+      // must be set because {node_field_revision}.log is a text column and
+      // therefore cannot have a default value. However, it might not be set at
+      // this point (for example, if the user submitting a node form does not
+      // have permission to create revisions), so we ensure that it is at least
+      // an empty string in that case.
+      // @todo Make the {node_field_revision}.log column nullable so that we
+      //   can remove this check.
       if (!isset($record->log)) {
         $record->log = '';
       }
     }

Proposed resolution

Make the {node_field_revision}.log column nullable so that we can remove this check.

User interface changes

No.

API changes

No.


Viewing all articles
Browse latest Browse all 294303

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>