Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 298410

Make MultiWidthLayoutBase non-internal

$
0
0

Problem/Motivation

In our contrib DROWL Layouts module we're using MultiWidthLayoutBase as basis.

Now upgrade_status reports

Class Drupal\drowl_layouts\Plugin\Layout\DrowlLayoutsMultiWidthLayoutBase extends @internal class Drupal\layout_builder\Plugin\Layout\MultiWidthLayoutBase.

see related issue: #3350603: Discuss how to fix extending an internal Drupal core base class

MultiWidthLayoutBase description says:

Base class of layouts with configurable widths.

but
@internal Plugin classes are internal.

MultiWidthLayoutBase is a very helpful base class for contrib multi width layouts. I don't think it would make sense to duplicate the whole class instead?

Steps to reproduce

Implement a layout extending MultiWidthLayoutBase and check the module via upgrade_status or similar tools.

Proposed resolution

Make MultiWidthLayoutBase non-internal

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 298410

Trending Articles