Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291388

Provide BC for ImageStyleDownloadController

$
0
0

Problem/Motivation

Multiple contrib modules are broken since ImageStyleDownloadController::deliver() now takes a string of the expected scheme for derivatives as a required parameter

Steps to reproduce

AVIF: #3450240: Drupal 10.3 compatibility
Stage File Proxy: #3450243: Drupal 10.3 compatibility
WebP: Probably also broken

Proposed resolution

Provide default value and throw a deprecation error.

public function deliver(Request $request, $scheme, ImageStyleInterface $image_style, ?string $required_derivative_scheme = null) {
  if ($required_derivative_scheme === NULL) {
    // @todo throw a deprecation.
    $required_derivative_scheme = $scheme;
  }
  // ...
}

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 291388

Trending Articles