Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293242

Add additional test coverage for DialogRenderer::getTitleAsStringable()

$
0
0

Problem/Motivation

Follow up from #3443959: DialogRenderer::getTitleAsStringable() does not support all return types of TitleResolverInterface::getTitle() from @catch

I think we should have test coverage for the bug, but also I think we might want to open a dedicated issue for that and fix the regression before 10.3.0 beta so that various contrib aren't stuck with an unresolvable blocker. Bumping to critical and tagging as beta target.

Steps to reproduce

Create module in which in modulename.routing.yml file , add _title_callback
Add ajax link on any page that 'll be open in modal:
<a class="use-ajax" data-dialog-type="modal" href="/admin/content">Modal Page</a></p>
Here in the href of anchor tag goes the path of that page that defined in .routing file along with _titile_callback(key)

Proposed resolution

Add additional test coverage that covers that ticket

Remaining tasks

Implement
Review

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A


Viewing all articles
Browse latest Browse all 293242

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>