Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291420

getProcessPlugins() normalises the process array twice

$
0
0

Problem/Motivation

If Migration::getProcessPlugins() is called with no parameter, it does this:

    if (!isset($process)) {
      $process = $this->getProcess();
    }

Migration::getProcess() calls getProcessNormalized(), so $process is now a normalised array.

However, getProcessPlugins() then does this:

      foreach ($this->getProcessNormalized($process) as $property => $configurations) {

This means that getProcessNormalized() has been needlessly called a second time.

Steps to reproduce

Proposed resolution

Only call getProcessNormalized() if $process was passed in.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 291420

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>