Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 296658

[regression] DateHelper::dayOfWeekName() returns untranslated name

$
0
0

Problem/Motivation

Comment for \Drupal\Core\Datetime\DateHelper::dayOfWeekName() says it returns translated string and it really make sense to return translation here. But in fact now it returns untranslated English name of the day. This change was brought by the
#3281557: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated . I didn't find the related discussion, suppose it's changed by mistake.

The change to use an untranslated string was added in #3281557-54: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated. No explanation is given and it is not discussed in later comments.

Proposed resolution

Return the original behavior - return translation from the method.

Remaining tasks

User interface changes

No.

API changes

No.

Data model changes

Just return state to previous.


Viewing all articles
Browse latest Browse all 296658

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>