Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 299308

CKEditor 5 has its own focus styles, should use the admin theme's (e.g. Claro's)

$
0
0

Problem/Motivation

If I tab into a CKeditor 5 body field the focus outline is in a light blue instead of the expected green. The blueish outline fails SC 1.4.11 and SC 2.4.7 (Unable to find the exact hex value for the blueish outline in the devtools but definitely less. with the color picker i got something around #8AAFEC which leads to a contrast of 2.2:1 tops without any padding in between the field and the outline also)

CKEditor 4
green focus outline for CKEditor 4 body field
CKeditor 5
blueish focus outline for CKEditor 5 body field

the really odd part is if i go into the devtools and trigger the focus state for the element i am able to get the expected green outline.
focus triggered in the devtools for ckeditor5
on the other hand i am unable to trigger the blue outline manually. tested on safari 13.1.2 and the latest firefox.

Steps to reproduce

- Go to /node/add/page or /node/add/article
- First select a CKEditor 4 text format
- tab until you reach the body field -> you should see the green outline around toolbar and body field
- Switch to CKEditor 5 text format
- tab until you reach the body field -> you should see a blueish outline around just the body field
- go to the devtools and find the div with the ck-editor__main class and manually trigger the focus state for the ckedtior5 body field -> you should see the green focus outline

I've set the component to Claro but I suppose it MIGHT be directly CKEditor5 related cuz I remember there was an issue moving the scope of the outline from toolbar+body field to body field only. If so please move the issue over to the CKEditor 5 component.

User interface changes

Before

ckeditor focus

After

ckeditor focus, after


Viewing all articles
Browse latest Browse all 299308

Latest Images

Trending Articles



Latest Images

<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>