Core migration issues
Next video meeting 2025-01-02 (tentative)
Hello all, it’s time for the biweekly migration subsystem meeting. The meeting will take place in slack in various threads. This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every second Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. #3495035: [meeting] Migrate Meeting 2024-12-19). See the parent issue for an idea of the typical agenda.
➤Transcript will be exported and posted to the agenda issue. For anonymous comments, start with a 👤 emoji. To take a comment or thread off the record, start with a 🚫 emoji.
0️⃣ Who is here today?
| benjifisher | Hi! I am skipping an optional work meeting. |
| mikelutz (he/him) | :wave: |
| Dan Davis | Greetings |
| markie | Hello! |
| quietone | Hi, catching up. |
1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
2️⃣ Action items. To be added later.
| benjifisher | Review[#3258581]: @benjifisher |
| benjifisher | Review[#3421014]: @benjifisher |
| benjifisher | Chang record for[#2845340]: any volunteers? |
3️⃣ Statistics
4️⃣ Comment in this thread if you are looking for ways to contribute. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...
5️⃣ Previous minutes.
6️⃣ Announcements
7️⃣ Move I18nQueryTrait from content_translation to migrate_drupal
| benjifisher | https://www.drupal.org/project/drupal/issues/3258581 |
| benjifisher | This is on my list to review. |
| benjifisher | I have some time off in the next two weeks, so I expect I will get to it. |
| benjifisher | The tricky part of this is coming up with automated tests. There is progress since the last time I looked. That is promising. |
| quietone | I'd like to know what is in the simpletest error log that the test is checking. |
8️⃣ Convert MigrateSource plugin discovery to attributes
| benjifisher | https://www.drupal.org/project/drupal/issues/3421014 |
| benjifisher | From my Comment #68:
If we can get this issue done, then I think we can have a separate issue to remove source_module from Drupal\migrate\Attribute\MigrateSource, create a migrate_drupal class that extends it, and add source_module there.
@mikelutz (he/him), @quietone: what do you think of that plan? Basically, I want to decouple any changes to source_module from this issue.
|
9️⃣ migrate mapping & messages table names are truncated, can lead to incorrect mapping lookups
| benjifisher | https://www.drupal.org/project/drupal/issues/2845340 |
| benjifisher | This issue makes me really nervous. What has more potential for disruption than changing the names of existing database tables? What if some sites have custom code (PHP or shell scripts or ...) that hard-codes the table names? |
| benjifisher | But catch and daffie (maintainer of the Database API) both commented on the issue, and neither seems concerned by this. |
| mikelutz (he/him) | I’m not super concerned either. The database structure is not part of the BC promise, all that is promised not to break is the interface to the map plugins. If you are hard coding database table names in custom scripts, that is on you to know they can be broken. |
| benjifisher | I commented on the issue:I am worried about how disruptive this change could be. Since both catch and daffie have commented on this issue, and neither seems concerned about that, I guess it is OK. But I am adding the tag for a change record (NW for that) and I am adding a release-notes snippet to the issue summary. |
1️⃣0️⃣ Thanks for participating! I added some action items to 2️⃣. Continue commenting on the threads. and we will post a transcript to the issue soon.