Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294800

Mark several more modules as hooks converted from procedural to OOP

$
0
0

Problem/Motivation

Follow-up from #3491275: Mark fully converted core modules as converted to OOP hooks. Let's make the changes we need to make to mark the remaining modules.
Modules that implement hooks that cannot be converted we use the #[StopProceduralScan] Attribute.
This is for all modules except those in the remaining tasks.

Would be great to do a before/after comparison of drush install to see if/how much memory and potentially time we save.

Steps to reproduce

N/A

Proposed resolution

Add #[StopProceduralScan] Attribute to modules that have hook_requirements, hook_hook_info or hook_module_implements_alter
Move procedural hooks to top of files that must remain
Convert unconverted hooks

  • block_themes_installed
  • media_library_form_views_form_media_library_page_alter
  • theme_suggestions and alters

If there is not already a services file create it

Do not add the attribute to jsonapi.module because there are no functions.
If a module has no .inc or .module files do nothing. E.G. page_cache
If a module only has procedural functions that need to be scanned do nothing E.G. package_manager
Modules changed:

  • big_pipe
  • block
  • ckeditor5
  • content_translation
  • file
  • image
  • jsonapi
  • layout_builder
  • layout_discovery
  • navigation
  • node
  • pgsql
  • search
  • taxonomy
  • views
  • views_ui
  • workspaces

Remaining tasks

Follow ups:

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A


Viewing all articles
Browse latest Browse all 294800

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>