Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 298090

Refactor LinkFieldTest, convert some methods to a Kernel test

$
0
0

Problem/Motivation

LinkFieldTest::testLinkFormatterQueryParametersDuplication doesn't make any HTTP requests so should be a Kernel test.
It has shared code with ::doTestURLValidation() in that test so it will require some unpicking.

Proposed resolution

  • Refactor to simplify test logic.
  • Provide urls for ::doTestURLValidation().
  • Combine ::testLinkFormatterQueryParametersDuplication(), ::doTestLinkFormatter() and convert to kernel test. Refactor.
  • ::doTestLinkSeparateFormatter() convert to kernel test. Refactor.
  • ::doTestLinkTypeOnLinkWidget() convert to kernel test

Remaining tasks

Decide if method testNoLinkUri - need to be converted?

User interface changes

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 298090

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>