Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293902

[meta] Fix 'Drupal.Files.LineLength' coding standard

$
0
0

Problem/Motivation

Part of #2571965: [meta] Fix PHP coding standards in core.

Steps to reproduce

Proposed resolution

Make the changes by type of fix to make it easier for reviews. This also means that the child issues will likely not be enforcing the rule in phpcs.xml.dist.

Commented out code often exceeds the line length. For these, keep the code as is and and ignore lines around the code. See #2742881: Can inline comments end with semicolons and #2607574: Don't add dot with inline comments containing code with semicolon.

  • In-line comments #3497105: Fix LineLength for inline comments
  • When the above is fixed, the bulk of the violations are fixed. Now, create child issues to fix the violations by directory and enable the sniff for that directory.

Completed

This issue will enable the sniff and fix any remaining problems.

Find issues in each group by

  1. Add <rule ref="Drupal.Files.LineLength"/> to phpcs.xml.dist
  2. Run phpcs --standard=core/phpcs.xml.dist --report-width=250 --report=code > a.txt
  3. Grep the results as needed

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 293902

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>