Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 297347

Tabledrag misalignment and "Show row weights" link

$
0
0

Problem/Motivation

The items in a tabledrag (menu, taxonomy, etc) are shifted up and not vertically centered with the drag handle.

menu

Looking at the HTML, I see that the handle in 11.0.11 went from

<a href="#" title="Move in any direction" class="tabledrag-handle js-tabledrag-handle"></a>

to this in 11.1.0
<a href="#" title="Move in any direction" class="tabledrag-handle"><div class="handle"></div></a>

which seems to indicate that it's coming from /core/misc/tabledrag.js instead of /core/themes/claro/js/tabledrag.js

The "Show row weights" link was also affected in a similar way.
show row weights

I suspect it has something to do with the recent changes is asset order: https://www.drupal.org/node/3473558

Steps to reproduce

Go to any form with a tabledrag element: /admin/structure/menu/manage/admin or /admin/structure/block or /admin/config/content/formats/manage/basic_html
Notice that the drag handle and text are not aligned and "Show row weights" is a blue text link.

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet


Viewing all articles
Browse latest Browse all 297347

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>