Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 313455

Node module's "use_admin_theme" setting is misnamed, since it's about more than just the theme

$
0
0

I think the Node module's "use_admin_theme" setting has an inaccurate developer-facing name, since the code (see for example https://api.drupal.org/api/drupal/core%21modules%21node%21src%21EventSub...) uses it to determine if node-related paths are considered "administrative"in general. Whether or not they use the admin theme is simply one part of that.

For more background, see #2139341-1: path_is_admin() is abused by "use_admin_theme" and other discussion in that issue.

I propose that this setting be renamed to something else, maybe something like "node_edit_is_admin".

The user interface could probably stay the same (and continue to refer to this setting as being about the administration theme only), but it could potentially change also if there is a good way to explain this distinction to site owners.

I am filing this against Drupal 8 for now, although I'm not really sure there's a good way to make this change in a backwards-compatible manner.


Viewing all articles
Browse latest Browse all 313455

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>