Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295807

The default revision can not be reverted (to) when there are pending revisions

$
0
0

Problem/Motivation

Followup for #3323788: Revert and Delete actions should not be available for the current revision.

When an entity has pending revisions (e.g. by making changes in a workspace), you can not revert to the default revision, while you can revert the latest (workspace) revision. This doesn't make sense and it was actually one of the goals of the issue mentioned above, but somehow missed in the implementation.

Proposed resolution

Forbid the revert operation for latest revisions instead of default ones.

Remaining tasks

Review.

User interface changes

Before:

After (with pending revisions):

After (without pending revisions):

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Original issue summary

When viewing revisions inside a workspace, the view includes links that respond with 404 page not found.

Steps to reproduce

1. create a node
2. create a workspace
3. switch to the workspace and create a new revision of a node
4. view revisions - the revision in the workspace is shown as the current revision
5. click on revert for the other revision (i.e. the current live revision)
6. this page responds with 404


Viewing all articles
Browse latest Browse all 295807

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>