Problem/Motivation
Follow-up to #2551725-14: Remove system_requirements() SafeMarkup::set() use with 'value' key
system_requirements() php warnings and errors use the same key, so only one is ever shown
steps to reproduce
ways of making php errors
- get an old version of php (or hack core to make it think it is old) (either pre 5.6.5 or 5.5.21)
- get an old version of php (or hack core to make it think it is old) (pre 5.5.9)
- disable phpinfo (or hack core to make it think it is not there)
*steps for install phase*
- make it so the install will fail (rename settings.php)
- make warnings or errors show
- attempt to install
- look at the requirements page
*steps for runtime phase*
- install
- make warnings or errors show
- look at admin/reports/status
Proposed resolution
Use different keys for each message (and maybe different titles)
or
(dont do this, cause some are warnings and some are errors) append the message descriptions so all the info that is relevant gets shown.
add test coverage that messages show when they should, (especially a test case where more than one php message is relevant)
Remaining tasks
| Task | Novice task? | Contributor instructions | Complete? |
|---|---|---|---|
| Create a patch | Instructions | ||
| Add automated tests | Instructions | ||
| Manually test the patch | Novice | Instructions | |
| Add steps to reproduce the issue | Novice | Instructions | (done) |
| Embed before and after screenshots in the issue summary | Novice | Instructions | |
| Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
when more than one requirement message is relevant, they will each show.
API changes
no