Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293926

Convert the comments administration screen to a view

$
0
0

Updated #204

Problem/Motivation

Part of #1823450: [Meta] Convert core listings to Views. This also helps solve problems for #1978904: Convert comment_admin() to a Controller and #1946348: Convert all of confirm_form() in comment.admin.inc to the new form interface which currently needs special handling for confirm delete forms.

Proposed resolution

Converting the admin/content/comment* page to a view with operations would keep it more inline with the rest of core listing pages.

Remaining tasks

Fix failing tests.
Review.
Manual testing.

User interface changes

Before Empty


After Empty


Before With Comment


After With Comment


API changes

N/A

Beta phase evaluation

Copied from https://www.drupal.org/node/1823450#beta-evaluation

This is appropriate for 8.0.x.

It is a major task that has impact greater than disruption, so it can proceed in 8.0.x.

Reference: https://www.drupal.org/core/beta-changes
Issue categoryTask because the functionality of these listings is already in core (with custom code)
Issue priorityMajor because this Meta is about replacing core listings in many places, across systems, and has community consensus for being important. Not critical because we can release 8.0.0 without completing the conversion to views and do it in a later release. Keeping the custom code (not converting a listing) will not cause severe performance or usability regressions.
Prioritized changesA bit, it maybe would reduce fragility by re-using views code and getting rid of custom listing code.
DisruptionIt will not be disruptive for core/contributed and custom modules/themes because it will not require a BC break/deprecation/widespread changes since changes are isolated to core listing custom code.

Viewing all articles
Browse latest Browse all 293926

Trending Articles