Problem/Motivation
The ContentNegotiation class is only used in the NegotiationMiddleware class. It is trivial in size and is not useful anywhere else. Let's simplify by just moving its functionality into the middleware.
Proposed resolution
* Move the getContentType() method from the ContentNegotiation class to NegotiationMiddleware and make it protected.
* Adapt NegotiationMiddleware to call the method on itself instead of on ContentNegotiation.
* Remove the dependency of NegotiationMiddleware on ContentNegotiation.
* Remove ContentNegotiation entirely (including from services.yml)
* Dance.
Remaining tasks
Do it.
User interface changes
none
API changes
nothing significant.
Beta phase evaluation
Issue category | Task because it's just general cleanup |
---|---|
Issue priority | Normal because nothing's actual broken. This is mostly just tidiness, with maybe a micro-optimization benefit |