Updated: Comment #4
Problem/Motivation
#1846172: Replace the actions API added:
+ $this->controllers['form'][$operation][$entity_type]->setOperation($operation);So we dont have to put $operation in the createInstance and __construct
Proposed resolution
Update the patterns in core to not use $operation in createInstance and __construct
(#1984702: Convert menu.module's page callbacks to Controllers is going to fix menuForm which used it in #1945226-143: Add language selector on menus,
so we are not doing that pattern fix here to avoid having to reroll it too much.
Remaining tasks
- (done) Find all the places. (ag "createInstance.*operation")
- (done) Make initial patch
- review
User interface changes
No.
API changes
? uh...
