Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291123

Generated .htaccess files should have a trailing line break

$
0
0

To comply with the Drupal coding standards the generated .htaccess files in the public and private files directories should end in a trailing \n character.

All text files should end in a single newline (\n). This avoids the verbose "\ No newline at end of file" patch warning and makes patches easier to read since it's clearer what is being changed when lines are added to the end of a file.

The comment about "No newline at end of file" probably isn't relevant as you wouldn't be patching generated content, but it is slightly confusing when you use the cat .htaccess command there is no new line before the next command.

Patches for D8 and D7 are attached.

AttachmentSizeStatusTest resultOperations
drupal-generated-htaccess-new-line-d8.patch3.45 KBIdlePASSED: [[SimpleTest]]: [MySQL] 50,410 pass(es).View details | Re-test
drupal-generated-htaccess-new-line-d7-do-not-test.patch1.76 KBIgnoredNoneNone

Viewing all articles
Browse latest Browse all 291123

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>