Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 298090

Deprecate Comment::permalink() method and rename it to not be ambiguous with ::uri()

$
0
0

Problem/Motivation

On CommentInterface we have two different methods CommentInterface::permalink and EntityInterface::uri. We also have comment_uri so If we want to remove comment_uri which method will replace it and why?

Proposed resolution

Please clarify the difference and document it.

Remaining tasks

Discussion

User interface changes

None

API changes

None

#2010202: Comment permalinks are lacking context and present a Usability regression (for e.g. drupal.org)
#2111419: Remove CommentManager::getParentEntityUri() in favor of Comment::permalink()
#1978904: Convert comment_admin() to a Controller
#1970360-78: Entities should define URI templates and standard links

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue categoryTask because it's a deprecation of an existing interface method, renaming it to prevent ambiguity.
Issue priorityNormal, non-critical.
DisruptionImpact > Disruption, as there's virtually no disruption (only two changed theme variables and two controller method names), and the impact is to reduce the possibility of confusion of what the difference between Comment::permalink and Comment::uri is.

Viewing all articles
Browse latest Browse all 298090

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>