Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295780

[573] Use csslint as a weapon to beat the crappy CSS out of Drupal core

$
0
0

Problem/Motivation

I know morten likes to complain about the CSS in Drupal core. And while he does love arguing, its much easier to change the CSS in core if we have useful metrics to show why the CSS is crappy.

Proposed resolution

Stubbornella (Nicole Sullivan) has been a long-time advocate of simple CSS to improve front-end performance. Complex selectors take more time for browsers to match against them. Needlessly-complex selectors lead to crazy cold-war-scenario specificity escalation as each rule tries to out-specify the more general rules.

She has also just released an open-source tool called csslint that we can use to test our current CSS rules.

http://www.stubbornella.org/content/2011/06/15/css-lint-open-sourced/
AND
http://csslint.net/

We've declared which rules we choose to follow inline with our CSS standards in #2222049: Add a .csslintrc file that's in line with our CSS standards

For those wishing to run csslint locally, follow the instructions for the Drupalcore frontend toolkit

Remaining tasks

Module CSS

ModuleIssues
block#2422399: Rewrite block.admin.css inline with our CSS standards
config_translation#2485397: Clean up config translation CSS inline with our CSS standards
content_translation#2485409: Clean up content translation CSS inline with our CSS standards
contextual#2485417: Clean up contextual CSS inline with our CSS standards
editor#2485425: Clean up editor CSS inline with our CSS standards
field_ui#2408469: Rewrite field ui components inline with our CSS standards
file#2485431: Clean up file CSS inline with our CSS standards
language#2485439: Clean up language CSS inline with our CSS standards
locale#2485497: Clean up locale CSS inline with our CSS standards
node#2485505: Remove CSSlint errors from node module css
quickedit#2408561: Rewrite quickedit CSS inline with our CSS standards
shortcut#2485375: Clean up shortcut CSS inline with our CSS standards
simpletest#2483913: Clean up simpletest.module.css
system#2395853: Split system.module.css and system.theme.css files into SMACSS style components#1663170: Clean up system.module.css#1663184: Clean up system theme css
toolbar#2419135: make toolbar module follow the css documentation
tour#2485293: Clean up tour.module.css
views_ui#2408525: Rewrite Views UI CSS inline with our CSS standards - Part 1

User interface changes

None

API changes

None


Viewing all articles
Browse latest Browse all 295780

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>