Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295149

Some cleanup in WebTestBase regarding modules

$
0
0

PHPDoc in WebTestBase::setUp() states that it would take a parameter, but it doesn't. Seems to be a leftover.

Also, the $modules property should be defined and documented in WebTestBase.
The fact that it isn't, might be to allow for collecting the $modules from inheriting classes with this code:

<?php
   
while ($class) {
      if (
property_exists($class, 'modules')) {
       
$modules = array_merge($modules, $class::$modules);
      }
     
$class = get_parent_class($class);
    }
?>

but maybe we can solve that differently.
It would really be nice to replace all the same generic PHPDocs by @inheritdoc in the test classes.


Viewing all articles
Browse latest Browse all 295149

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>