Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291607

Replace the "Primary menu" component with a reusable component in Bartik.

$
0
0

Follow-up to #1342054: [META] Overhaul Bartik's code.

Problem/Motivation

  1. Bartik's template files need to be assessed and cleaned up of redundant markup, bad formatting and ID's.
  2. Bartik's CSS files need to follow Drupal's CSS Coding Standards.

Proposed resolution

For this issue we take "primary-menu.css" within Bartik in css/components/primary-menu.css plus any template file associated with the CSS and clean them up.

Remaining tasks

  • Write a patch containing as much as the above as possible.
  • Post a patch with screenshots.
  • Visual review of a patch - check the secondary menu visually with and without patch applied. Take screenshots.
  • Code review of a patch - check the code follows coding standards, suggest improvements if needed in a comment.
  • Produce a new patch with improvements if needed.

User interface changes

None

API changes

None

Data model changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue categoryTask because it is refactoring CSS and templates in Bartik
Issue priorityNot critical because Bartik functions fine we are just doing cleanup tasks
Unfrozen changesUnfrozen because it only changes CSS and markup
Prioritized changesThe main goal of this issue is usability of the Bartik's codebase
Disruptionnon-Disruptive as it is just changing markup and CSS

Viewing all articles
Browse latest Browse all 291607

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>