Quantcast
Viewing all articles
Browse latest Browse all 294646

Improve reverse proxy documentation in default.settings.php

Problem/Motivation

The reverse proxy configuration and documentation in default.settings.php has some minor issues:

- copy/paste errors: most of the comments refer to "client protocol" instead of the setting's actual meaning
- confusing/wrong default values: while most of the commented out $settings code lines have the actual default value, the doc comment has not (e.g. doc: "X-Forwarded-Proto", code/default setting: "X_FORWARDED_PROTO") - verified in Drupal\Core\StackMiddleware\ReverseProxyMiddleware
- unclear difference between "reverse_proxy_header" and "reverse_proxy_forwarded_header" (rfc 7239)

Proposed resolution

Is only a minor issue, but it still takes some time to figure out what's wrong, so it should be fixed by updating the documentation.

Remaining tasks

Needs review / merge.


Viewing all articles
Browse latest Browse all 294646

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>