Updated: Comment #0
Problem/Motivation
In #1874640: Rename edit module to quickedit, we are renaming the module, its PHP classes, and so on -- changes that need to be made as soon as possible following API freeze to avoid disrupting other work and to ensure the backend API is stable for the first beta.
It also makes sense to update frontend APIs to be similarly namespaced for quickedit. Frontend APIs are not bound by API freeze.
Proposed resolution
Update CSS, JS, and markup to be namespaced for quickedit
rather than edit
, possibly including:
- The
.edit
CSS class provided by the module. - Other CSS classes prefixed
.edit-
. (Use care when updating these; the prefix is also used elsewhere in core.) - Possibly the
data-edit-*
attributes that are added by the module's JS. Are these specific to quickedit, or do they have meaning outside the module? (There are non-Drupal results for, e.g.,data-edit-id
as an HTML attribute.) - The
edit
JS event. - JS theme method names, e.g.
Drupal.theme.editModal()
. - Other elements of the module's JS API.
Drupal.edit
is already renamed to Drupal.quickedit
in #1874640: Rename edit module to quickedit.
Remaining tasks
- The attached patch changes the theme method names, but does not yet rename CSS classes they correspond to.
- Determine what other renames are in scope for this issue.
User interface changes
TBD
API changes
There should be no backend API changes. JS API changes TBD.
Related Issues
Attachment | Size | Status | Test result | Operations |
---|---|---|---|---|
quickedit-js-renames-do-not-test.patch | 9.07 KB | Ignored: Check issue status. | None | None |