Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295818

Batch API uses request attributes instead of query in Symfony 3

$
0
0

Problem/Motivation

The semantics of Request::get() have changed in Symfony 3. Request attributes are now examined first before request query parameters. If you have an "op" request attribute AND an "op" query parameter at the same time as for example in update.php then the Batch API breaks.

Proposed resolution

Explicitly call $request->query->get() in the Batch API to only access URL query parameters and never request attributes.

Remaining tasks

Patch.

User interface changes

None.

API changes

None.

Data model changes

None.


Viewing all articles
Browse latest Browse all 295818

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>