Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 297447

Refactor machine name and title of custom block default body field

$
0
0

Follow up for #1871772-108: Convert custom blocks to content entities

Problem/Motivation

+++ b/core/modules/block/custom_block/custom_block.module
@@ -53,3 +157,161 @@ function theme_custom_block_block($variables) {
+function custom_block_add_body_field($block_type_id, $label = 'Block body') {
Minor: Should default to just "Body", I think.

+++ b/core/modules/block/custom_block/custom_block.module
@@ -53,3 +157,161 @@ function theme_custom_block_block($variables) {
+ $field = field_info_field('block_body');
+ $instance = field_info_instance('custom_block', 'block_body', $block_type_id);
...
+ 'field_name' => 'block_body',
I'm concerned about module namespace issues here; technically, this module-specific field should at least start with "custom_block_" as it is owned by custom_block.module.

Proposed resolution

Rename the field and the default title, refactor upgrade path

Remaining tasks

Rename the field and the default title, refactor upgrade path


Viewing all articles
Browse latest Browse all 297447

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>