Follow up for #1871772-108: Convert custom blocks to content entities
Problem/Motivation
+++ b/core/modules/block/custom_block/custom_block.pages.inc
@@ -0,0 +1,153 @@
+ return array('#theme' => 'custom_block_add_list', '#content' => $types);
...
+function theme_custom_block_add_list($variables) {
...
+ $output = '
- ';
I... hrm. We have (minor) wrong "node" class name in there, but I don't really get why the /add callback optionally renders a list of (existing?) custom blocks that may be added - shouldn't that be a different controller/callback?
In any case, do we really need a theme function for that? Can't we make it a simple table or something? :)
In more general terms there is duplication between theme_node_add_list() theme_custom_block_add_list() and theme_item_list().
Proposed resolution
Consolidate theme_node_add_list() and theme_custom_block_add_list().
Remaining tasks
Write the patch.
API changes
Removal of two theme functions.