Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 300589

Consider renaming Migrate's cckfield plugins

$
0
0

Problem/Motivation

cckfield plugins were introduced to make migrating cck fields easier but we're now using the same plugin type for D7 fields as well.

This is confusing for developers as 'CCK' was primarily a Drupal 6 concept whereas Drupal 7 had the same functionality in core under the name 'Field'.

Proposed resolution

Rename the plugin type to 'FieldPluginBase' as suggested in #2631736: Cckfield Plugins must distinguish core versions to make it less confusing.
Introduce a backwards compatibility layer for 'CckFieldPluginBase' so that classes that extend that base class don't stop working.

Comment #112 is what we'd like to commit to core eventually.

Remaining tasks

The patch in #112 has become too unwieldy to review, so we will split the patch in two:

  1. The conversion of the CckFieldPuginBase class to just FieldPluginBase, BC layer and required changes to the core migrations using the CCK field plugins. A single conversion a class extending the CckFieldPluginBase.
  2. All the other conversions of classes extending CckFieldPluginBase and their unit tests. This will be reviewed and handled in a follow-up issue

User interface changes

None.

API changes

  • Deprecated the CckFieldPluginBase class, and new FieldPluginBase class.
  • There isn't a BC for the plugin manager class, so Migration derivers etc, using the 'plugin.manager.migrate.cckfield' service will need to change to use the 'plugin.manager.migrate.field' service. BC break?

Data model changes

None.


Viewing all articles
Browse latest Browse all 300589

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>