Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293617

Display comment op links (delete, edit, reply, approve + contrib) via JS to prevent render caching granularity being per-user

$
0
0

Problem/Motivation

After #1991684: Node history markers (comment & node "new" indicator, "x new comments" links) forces render caching to be per user the situation for comment render caching got better. But in #1882482-105: [meta] Unify editing approaches in Drupal and #1605290-153: Enable entity render caching with cache tag support it's been discussed to further improve it by displaying the comment op links (delete, edit, reply etc.) over AJAX, so that we can apply full render caching of comments. I couldn't find an issue for this, so here it is.

Proposed resolution

Render comment op links similar to how contextual links are rendered over AJAX.

It would be nice to come up with an entity type agnostic way to do this, so that we can apply the same pattern for node links etc. There's plenty of contrib modules that adds user/role dependent stuff to those links that would break full render cache.

Remaining tasks

Discuss if this is something we want to do, and if so, code it.

User interface changes

None.

API changes

TBD.


Viewing all articles
Browse latest Browse all 293617

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>