Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 296275

Incorrect field assertions in AssertLegacyTrait

$
0
0

Problem/Motivation

The current assertFieldById() and assertNoFieldById() both incorrectly check the field. The current implementations (indirectly) the findField() method. This causes the following problems:

  • The field is searched generically by input id, name or label instead of only the ID. This leads to false positives for assertNoFieldById()
  • Buttons are ignored now, causing no results on a valid ID. They were not ignored in the WebTestBase and should therefore still work in this legacy trait.

Proposed resolution

Rewrite the implementations to use the findById() methods and keep the thrown exceptions the same so we don't break BC.

User interface changes

None.

API changes

None.

Data model changes

None.


Viewing all articles
Browse latest Browse all 296275

Trending Articles