Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295245

Adding symfony/dom-crawler with a version limit like ">=2.8.13 <3.0" is problematic

$
0
0

Problem/Motivation

In #2808085: Pipe char in locators break Mink and Symfony element search we added symfony/dom-crawler to core/composer.json with the version restriction of ">=2.8.13 <3.0". This is problematic because if people have done a composer install of the Drupal project doing something like
composer require drupal/core "^8.3.0-rc1"
well result in something like:


  Problem 1
    - Conclusion: don't install drupal/core 8.3.0-rc2
    - Conclusion: don't install drupal/core 8.3.0-rc1
    - Conclusion: don't install drupal/core 8.4.x-dev
    - Conclusion: remove symfony/dom-crawler v3.1.9
    - Installation request for drupal/core ^8.3.0-rc1 -> satisfiable by drupal/core[8.3.0-rc1, 8.3.0-rc2, 8.3.x-dev, 8.4.x-dev].
    - Conclusion: don't install symfony/dom-crawler v3.1.9
    - drupal/core 8.3.x-dev requires symfony/dom-crawler >=2.8.13 <3.0 -> satisfiable by symfony/dom-crawler[2.8.x-dev, v2.8.13, v2.8.14, v2.8.15, v2.8.16, v2.8.17, v2.8.18].
    - Can only install one of: symfony/dom-crawler[2.8.x-dev, v3.1.9].
    - Can only install one of: symfony/dom-crawler[v2.8.13, v3.1.9].
    - Can only install one of: symfony/dom-crawler[v2.8.14, v3.1.9].
    - Can only install one of: symfony/dom-crawler[v2.8.15, v3.1.9].
    - Can only install one of: symfony/dom-crawler[v2.8.16, v3.1.9].
    - Can only install one of: symfony/dom-crawler[v2.8.17, v3.1.9].
    - Can only install one of: symfony/dom-crawler[v2.8.18, v3.1.9].
    - Installation request for symfony/dom-crawler (locked at v3.1.9) -> satisfiable by symfony/dom-crawler[v3.1.9].

It is possible to mitigate by doing:
composer require symfony/dom-crawler "2.8.18"
But this feels really wrong.

Steps to reproduce:

  1. composer create-project drupal-composer/drupal-project drupal --stability dev --no-interaction
  2. cd drupal/
  3. composer require drupal/core "^8.3.0-rc1"

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes


Viewing all articles
Browse latest Browse all 295245

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>