Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291336

Incorrect behaviour for block page visibility

$
0
0

Problem/Motivation

When leaving the "listed pages" text area empty in "Pages" block visibility, the options "Show for the listed pages" and "Hide for the listed pages" do the exact opposite of what they claim, they work as though there was an entry * in the list, i.e.:

  • Show for the listed pages will result in the block showing on all pages when the list is empty
  • Hide for the listed pages will result in the block showing nowhere when the list is empty

For an empty list, "Show on the listed pages" should not show the block anywhere. And, "Hide on the listed pages", should have the block show up on every page, when the list is empty.

Proposed resolution

This issue could be solved in several ways, we should probably just discuss what is the best way forward. The possible options:

  • Make the options just work as advertised, i.e. an empty list will cause the exact opposite of entering a single * for both options
  • Make it impossible to empty the list, defaulting it to "*" when left empty (this should probably be reported in a user message).
  • Don't change anything except add a little explanation to the UI stating that leaving the list empty is equivalent to "all".
  • Uncheck "Show for the listed pages" if pages textarea is empty

One consideration is that the default currently causes the block to show everywhere, which in itself is probably a good default. It's just that it is being achieved by combining "Show on the listed pages" with an empty list, which at least caused me to select "Hide on the listed pages", expecting that to result in the block showing everywhere.

Remaining tasks

  1. Decide on resolution
  2. Implement resolution

User interface changes

Undetermined

API changes

None.


Viewing all articles
Browse latest Browse all 291336

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>