Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291671

Rename offcanvas to two words in code and comments.

$
0
0

Problem/Motivation

The code and comments in the Settings Tray module inconsistently uses "Off Canvas" as 2 words and 1 word.

This was added to #2784443: Move off-canvas functionality from Settings tray module into drupal.dialog.ajax library so that other modules can use it but it makes sense to do this a separate issue

Proposed resolution

Change all occurrences of offcanvas to 2 words Off Canvas under /core/modules/outside_in, i.e there should be no examples of "offcanvas" or "Offcanvas" in this folder anywhere.

For example

*.js and *.css file names
from offcanvas.* to off-canvas

CSS ids and class names
offcanvas to off-canvas

outside_in.services.yml
offcanvas to off_canvas

php variable names with underscores
From offcanvas to off_canvas
php variable names with camelcase
From Offcanvas to OffCanvas

To see the previous see the previous attempt to do this see this diff file: https://www.drupal.org/files/issues/interdiff-24-28_6.txt

Remaining tasks

do it

User interface changes

None

API changes

None

Data model changes

none


Viewing all articles
Browse latest Browse all 291671

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>