Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294795

Improve naming of ViewExecutable::addItem(), ::getItem() & Co.

$
0
0

Updated: Comment #6

Problem/Motivation

In ViewExecutable several methods dealing with Views handlers are using ...Item() instead. Especially as ViewExecutable::getItemsPerPage() and ViewExecutable::setItemsPerPage() are used in a total different context this may be very confusing.

Proposed resolution

Renaming the following methods to use "Handler" instead of "Item":

  • addItem() => addHandler()
  • generateItemId() => generateHandlerId()
  • getItems() => getHandlers()
  • getItem() => getHandler()
  • removeItem() => removeHandler()
  • setItemOption() => setHandlerOption()

Remaining tasks

-

User interface changes

-

API changes

Public methods of \Drupal\views\ViewExecutable are renamed:

  • addItem() => addHandler()
  • generateItemId() => generateHandlerId()
  • getItems() => getHandlers()
  • getItem() => getHandler()
  • removeItem() => removeHandler()
  • setItemOption() => setHandlerOption()

Developers dealing with handlers associated to a view need to rename their method calls.
The AddItem form is now called AddHandler.


Viewing all articles
Browse latest Browse all 294795

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>