Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291502

Rename module CSS files to match new file naming convention

$
0
0

Problem/Motivation

The BAT (base-admin-theme) file organization we started to do in Drupal 8 was a fantastic idea. See http://drupal.org/node/1089868

It works really well, but its names conflict with the SMACSS categorization we're using in Drupal 8. "base" and "theme" means something else in SMACSS. So we just need to rename them.

Note: this is part of the meta issue: #1921610: [Meta] Architect our CSS

Proposed resolution

MODULE.base.css becomes MODULE.module.css.
MODULE.admin.css stays the same (but requires adding a MODULE.admin.skin.css so admin themes can override the default skin).
And MODULE.theme.css becomes MODULE.skin.css.

In addition, since our template files are now in a templates sub-directory of a module, we should do the same for the CSS. Note that the toolbar, tour and views modules already put styles in a css/ directory.

This is part of the CSS standard described at http://drupal.org/node/1887922

This patch (one of several issues) just converts all of the core modules that only have *.admin.css files and puts them in a css/ sub-directory:

  • block
  • color
  • dblog
  • entity_reference
  • field_ui
  • file
  • filter
  • help
  • language
  • layout
  • locale
  • menu
  • translation_entity
  • update

Remaining tasks

After this issue's completion, we still have all the other steps outlined at #1921610: [Meta] Architect our CSS.

User interface changes

none

API changes

The system.module's CSS files will have new names.


Viewing all articles
Browse latest Browse all 291502

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>