Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291503

Small optimization for search on modules page

$
0
0

Problem/Motivation

An optimization was noticed, in the issue about adding search to tests lists. #1919470-6: Add a search field to the test overview page

Proposed resolution

Replicate optimization for the modules search, which was added in #1848064: Allow to filter modules by arbitrary search strings on the Modules page.

Remaining tasks

  • Discuss if makes sense on the modules search.
  • Implement.

User interface changes

No UI changes.

API changes

No API changes.

Original report by @tim.plunkett and @berdir

Follow up for #1919470-6: Add a search field to the test overview page and #7

+++ b/core/modules/simpletest/simpletest.jsundefined
@@ -99,4 +99,62 @@ Drupal.behaviors.simpleTestSelectAll = {
+    var searching = false;
...
+        searching = true;
...
+      else if (searching) {

@tim.plunkett

This seems like a performance improvement that could be mimicked in the module filtering.

@Berdir

I'm not sure the modules search needs this. Unlike this, searching already starts at the second characters, so there's only a single character on which we would not have to search on. And there are also considerably more tests than modules (close to 900 table rows..)

But I'm happy to apply it there as well if this is the correct approach to do something like this.


Viewing all articles
Browse latest Browse all 291503

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>