Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295295

Refactor tour module to use routes instead of paths

$
0
0

Updated: Comment #0

Problem/Motivation

Tour module relies on paths to decide when to display each tour.
In the new world order we should be using route names.

Proposed resolution

Switch out paths for route names

Remaining tasks

Reviews

User interface changes

None

API changes

Change to tour yml format

Original report by @username

Over in #1809352: Write tour.module and add it to core we need config entity queries where we can do path matching, this patch provides pattern matching on single value properties.

Would also nice to be able to have pattern matching on array properties too (tour config entity has a path array property on the entity and contains wildcards - ala the 'pages' textarea on the block placement configuration form).

Here's an example patch cobbled together after conversations with @chx.

Commit credit for @chx too as he rightly pointed out that I should be using preq_quote() and some inconsistencies in my tests.


Viewing all articles
Browse latest Browse all 295295

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>