Updated #107
Title says it all.
Details
- The recent comments block had a very simple setting that allowed to configure the number of comments to show. Because one can easily configure the number of items (and more) in Views, this is "dropped" from the Block configuration screen.
- This patch reproduces an inconsistency that existed with the old block and should be fixed in a follow-up: The comments are sorted by their creation date, but their modification/updated date is displayed. Although the use-case of editing comments is not common (although, *cough* Drupal.org *cough*) the block may show, e.g. "sadf 2 hours ago", "asdf 1 second ago" and that (wrong) order. See #1938664: Recent comments block sorts by creation date but displays updated date for fixing this.
- The Views configuration files are very inconsistent in terms of their explicit-ness. Some settings are left out of the default config and, thus, saving a view without changing anything will result in a non-empty "diff" of the resulting configuration. Explicitly declaring all keys would make the config files *very* large, but I think there is no way around that, ultimately. Either way, this is not for this issue to solve. Because I generated the view by clicking it together in the UI, it is explicit in some parts and not in others (just like all other default views currently). See #1938654: Export all properties of all views handlers and plugins for fixing this properly.
Discussion items
- As shown in the screenshot, the "3 hours" part of "3 hours ago" is wrapped in an < em > element by the view, whereas previously this was not the case. Because the view simply uses the default "Time ago (with "ago" appended)" display plugin, if we want to retain the previous behavior, I think we should change the output of that plugin in general (i.e. for every view that uses it) instead of overriding the markup specifically for this view. I have no opinion on whether we want to remove the < em > or keep it, though.
- The plugin name is kept as comments_recent as it was before. Because it belongs to comment module (without s) it might be better to name it comment_recent. I guess we should just leave this as is for now and wait for #1862600: Entity type names/IDs are not properly namespaced by owner (e.g., taxonomy.term vs. taxonomy_term) to happen.
Steps to test
- sudo rm -r sites; git checkout sites;
- git pull --rebase
- drush am 1938062
- drush -y si --account-pass=admin --db-url="mysql://root:root@localhost/d8-patch" --site-name=1938062
- get devel (git clone --branch 8.x-1.x http://git.drupal.org/project/devel.git)
- under Extend, enable the Devel generate module
- generate nodes and comments admin/config/development/generate/content be sure to change maximum number of comment per node (I used 4)
- ?
Oops. devel gets an error to. Can use filtered html instead of wysiwyg formatter to get around error when making comments.
Remaining Tasks
These are blocking this issue.
- wont fix: #1967460: Display the block title and populate the machine name for views blocks
- doing it here: #1957276: Let users set the block instance title for Views blocks in the Block UI
- #1956134: Provide helpful editing links on "admin/structure/block" for different blocks (menu, views etc.)
- #1957346: Add some settings on the block display to allow overrides on the block instance configuration (will enable us to fix usability regression caused here.
- (done) #57 address machine name (can be/should be done in this patch)
- make sure usability is addressed (http://drupal.org/core-gates#usability)
- (done) profiling #76
- (done) shows "items per block"#2072181: Change title in blocks form for items_per_page
UI Changes
After screenshots
placing the block
editing the block
the block
hovering on the block, shows contextual edit. both the configure block and edit view links work.
Follow-up issues
- #1954968: Required CKEditor fields always fail HTML5 validation (see #43)
- (need to create issue) major styling issues (see #43 and #45, #47, #49)
- #1862600: Entity type names/IDs are not properly namespaced by owner (e.g., taxonomy.term vs. taxonomy_term) will take care of plugin name comments_recent vs comment_recent (see second discussion item)
- need to open one for the time ago use of < em > (see first discussion item and #43)
- #2054993: Refactor and possibly deprecate comment_get_recent()
- (needs issue created) collapse machine name field on place (edit) block screen. See #98
Related Issues
- #1807322: Filter comments taking into account the current content language might not be needed when we get this issue done.
- #1987396: comment.module - Convert theme_ functions to Twig (twig collision. see #78)
- #19734: add 'Pending Comments' block
- (needs issue created) dialog will not scroll correctly. See #98