Problem/Motivation
The Outside In prototype introduced in #2753941: [Experimental] Create Outside In module MVP to provide block configuration in Off-Canvas tray and expand site edit mode allows a user to configure page elements in context. Something very frustating happens when trying to edit the page title.
This is partly an existing usability issue with the page title block (the title and display title make no sense for that block), but it's made much worse with the introduction of a module that lets me click on those words and get a sidebar to do everything but change those words. There are several problems:
- The "Display title" checkbox makes no sense for this block.
- The "Display title" checkbox does not display the thing in the title box for this block.
- The contents of the title box are ignored.
- When I click on this, I don't actually want to configure this block at all. I want to edit the node title!
Proposed resolution
Since the nothing you can do to the page title block will actually have any visible effect it should be not get the "Quick Edit" contextual link provided by this module.
- Add new function _outside_in_is_block_editable() that will be called to determine if a block should exclude from getting the Quick Edit link. This sets the Main Content(which was already excluded) and Page Title block.
- Set an attribute data-outside-in-exclude on blocks should not include a Quick Edit link which will remove the link via Javascript. (It is very complicated to remove contextual links on the server side see @Wim Leers' comment in #12)
Remaining tasks
None
User interface changes
No "Quick Edit" contextual link for the Page Title block.
User doesn't get access of the Off-canvas form for the Page Title block which would have no effect anyways.
API changes
None
Data model changes
None