Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294952

Module install form has two "install" buttons that do different things

$
0
0

Problem/Motivation

The module install form (admin/modules) has two buttons that do different things:

  • Install new module downloads a module from outside the site and makes it available for installing via the Install button
  • Install installs the modules that were selected on the form

At the top is:

In HEAD, the bottom link is:
before_134.png
But the consensus is to change it to:
Screenshot_122.png
This has confused at least a few people on this issue.

Proposed resolution

Rename the first button "Add new module".

Remaining tasks

Contributor tasks needed
TaskNovice task?Contributor instructionsComplete?
Embed before and after screenshots in the issue summary NoviceInstructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standardsInstructions

User interface changes

Yes, button rewording.

Additionally, whatever wording change is made would need to be carried through to /admin/modules/install and /core/authorize.php. core/authorize.php considers the downloading to be "install" and the activation to be "enable," which is the opposite with the proposed solution for /admin/modules.

/admin/reports/updates also has this button as +Install new module or theme and would need to be updated to agree with the rewording, and /admin/reports/updates/install uses Install wording.

Further, if the reference to installing is no longer part of the first button, then /admin/modules/install may no longer be the appropriate URL, since it doesn't accomplish what the UI will be saying Install does.

For consistency, whatever change is made to these buttons and pages would also be made to /admin/appearance and /admin/theme/install.

API changes

Data model changes


Viewing all articles
Browse latest Browse all 294952

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>