Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 291669

ViewExecutable::setDisplay() will never return an invalid display ID

$
0
0

Because of this current logic like this in setDisplay():

<?php
$display_id
= 'default';
if (!
$this->displayHandlers->has($display_id)) {
 
debug(format_string('set_display() called with invalid display ID @display.', array('@display'=> $display_id)));
  return
FALSE;
}
?>

It will never return false for an invalid display ID, but just return the default.

It is also checking twice the the displayHandlers (displayBag) has the plugin.

We should take this opportunity to just tidy this method up.

AttachmentSizeStatusTest resultOperations
d8.tidy-setDisplay.patch2.27 KBIdleFAILED: [[SimpleTest]]: [MySQL] 52,192 pass(es), 10 fail(s), and 0 exception(s).View details | Re-test

Viewing all articles
Browse latest Browse all 291669

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>