Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 301255

Options module PHPUnit tests extend a Simpletest base class

$
0
0

Problem/Motivation

The following PHPUnit tests in the Options module extend a Simpletest base class (\Drupal\field\Tests\FieldTestBase):

  • \Drupal\Tests\options\Functional\OptionsDynamicValuesTestBase
  • \Drupal\Tests\options\Functional\OptionsFieldUITest
  • \Drupal\Tests\options\Functional\OptionsFloatFieldImportTest
  • \Drupal\Tests\options\FunctionalOptionsWidgetsTest

According to the instructions at #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase), these tests should extend the new version \Drupal\Tests\field\Functional\FieldTestBase:

Any TestBase or Trait which is in the old /src/Tests/ location should remain there and be deprecated. Copy the TestBase or Trait file into the new location and alter the tests to use the new version. The deprecated class must not "use" the newly-moved class, but remain exactly as it is. Create a change record for the deprecation notice - one CR can cover all deprecations within a module.

Proposed resolution

Update the tests to extend the PHPUnit based \Drupal\Tests\field\Functional\FieldTestBase

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.


Viewing all articles
Browse latest Browse all 301255

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>