@alexpott:
Can we get a followup to remove \Drupal\Tests\search\Functional\SearchTestBase - the abstraction to just enable search and create content types if not standard looks unnecessary. I think it could use the same CR.
Problem/Motivation
Class \Drupal\Tests\search\Functional\SearchTestBase
almost useless after #2887411: Add $form_html_id to drupalPostForm in BrowserTestBase and convert SearchTestBase::submitGetForm() to BrowserTestBase::drupalPostForm(). Because it does not contain any methods.
All the logic is in the following code:
public static $modules = ['node', 'search', 'dblog'];
protected function setUp() {
parent::setUp();
// Create Basic page and Article node types.
if ($this->profile != 'standard') {
$this->drupalCreateContentType(['type' => 'page', 'name' => 'Basic page']);
$this->drupalCreateContentType(['type' => 'article', 'name' => 'Article']);
}
}
Proposed resolution
Decide whether this abstraction is needed. If not needed - replace all Functional\SearchTestBase
on BrowserTestBase
. And deprecated this class.