Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 295276

Create change record for all deprecated db_* functions

$
0
0

Problem/Motivation

Mostly everything in core/database.inc is deprecated starting from 8.0 but removal of usage require to @trigger_error() with a link to change record

This is a soft blocker for #2319859: [META] Deprecate contents of database.inc to deprecate remains

Also a soft blocker for lot of issues in #2848161: [meta] Replace calls to deprecated db_*() wrappers

Also this issue may patch all the places according to current deprecation standard https://www.drupal.org/core/deprecation as pointed in #2848817: Replace all calls to db_table_exists, which is deprecated.

Also setting default target is missing at "objectified" db subsystem #2947775: Move setting default target out of db_merge() and other deprecated db_* functions - probably makes sense to mention at in separate CR

Proposed resolution

  1. Create change record mentioning all deprecated db_* functions + #2286235: Deprecate db_ignore_replica() and convert it to service
  2. Identify common pattern of message
  3. add regression test to core/tests/Drupal/KernelTests/Core/Database/DatabaseLegacyTest.php for each function (use group @legacy to annotate exception
  4. Promote in core gdo about that all since 8.6 extra call to trigger_error() will happen for all deprecated functions like

Remaining tasks

- decide on message for exception
- file CR draft listing functions and which of them will start throw exceptions on usage
- create patch to fix all @deprecated content in core/database.inc

User interface changes

no

API changes

no

Data model changes

no


Viewing all articles
Browse latest Browse all 295276

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>